-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better print behavior for low_order_moments() #7
Comments
It's a matter of implementing The result may contain the following fields: I suppose the default 'smart' printing would display min, max, mean and std if available, kind of like It makes sense to arrange the data into a table. Perhaps reuse pandas for printing? How about a code that maps |
I would like to think about the broader picture. The same 'issue' exists for all results/models. I suggest adding a
Attributes which are not expanded (complex and daal types) can be expanded by explicitly printing them. A conversion to a pandas data-frame seems applicable only in very special cases, like low order moments. A conversion to a dict looks more generic. pandas allows creating DFs from dicts. |
For algorithms we could print the parameters. This is more involved and probably less important. |
Yes, I'll second @fschlimb 's findings. It is mostly about having str methods when looking at a summary, and accessors to the values in the right type when needing a specific one (mean, variance as examples). |
done: generic print capability added for results and model through #48 |
The low order moments class has the advantage of being able to process an entire array of features, but does not make it easy to see the results without individually selecting it.
For printing the entire result array, it would be preferred to print ALL of the results if using the print() function.
From a data scientist perspective, better printing behavior would be useful especially in the Jupyter Notebook arena. Consequently if you add Dataframe support, it might make it easier for easier printing.
The text was updated successfully, but these errors were encountered: