Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

signal_callback should return an error when ring buf full #1817

Open
grgustaf opened this issue Feb 1, 2018 · 0 comments
Open

signal_callback should return an error when ring buf full #1817

grgustaf opened this issue Feb 1, 2018 · 0 comments
Assignees
Labels

Comments

@grgustaf
Copy link
Contributor

grgustaf commented Feb 1, 2018

When the ring buffer is too full, signalling a callback fails. To behave correctly, the caller should probably find out this and even though it's a pretty bad error, they can avoid making things worse by freeing up resources.

So probably the return value should be changed to something other than void and all callsites checked for proper error handling.

@grgustaf grgustaf self-assigned this Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant