Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

Symmetric Linear Quantization #11

Closed
vinutah opened this issue Jun 30, 2018 · 1 comment
Closed

Symmetric Linear Quantization #11

vinutah opened this issue Jun 30, 2018 · 1 comment

Comments

@vinutah
Copy link

vinutah commented Jun 30, 2018

Hi,

The math for the derivation of y_q under Symmetric Linear Quantization on the page
https://nervanasystems.github.io/distiller/algo_quantization/index.html seems incorrect.
I am not able to reason out to myself, the scaling of the bias term.

Thanks

@guyjacob
Copy link
Contributor

guyjacob commented Jul 1, 2018

You're right, there is an error in the scale factor of the bias. It should be the reciprocal of the what's in there now. That is, it should be: (q_x * q_w) / q_b.
And actually, the parentheses are wrong as well - the way it is now it implies the bias is added during the accumulation instead of after it.

Will fix - thanks for spotting it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants