INSP: change RsVariableMutableInspection to a LintInspection #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
RsVariableMutableInspection, introduced in #1143, to aRsLintInspectionand enables it by default.I think that this inspection is incredibly useful. I have been using the Rust plugin for more than two years and I had no clue about its existence, so I think that it would be good if we enable it by default, at least in nightly builds for now, to gather possible false positives.
I'll try to find cases where false positives happen and try to fix them to make this inspection better. If you know about any one reason why this shouldn't be enabled by default except for false positives, let me know.
Fixes: #1004