Refactor / Rename implicit named arguments in macro formatting

[blueglyph]

Environment

• IntelliJ Rust plugin version: 0.4.170.4627-221
• Rust toolchain version: 1.60.0 (7737e0b5c 2022-04-04) x86_64-pc-windows-msvc
• IDE name and version: PyCharm 2022.1.1 Professional Edition (PY-221.5591.52)
• Operating system: Windows 10 10.0
• Macro expansion engine: new
• Name resolution engine: new

Problem description

Variables that are captured in strings, for ex. "The value is {value}", are not renamed as expected.

Steps to reproduce

• Enter the following program:

fn main() {
    for i in ["One", "Two", "", "Last"] {
        if !i.is_empty() {
            println!("Hello, world! {i}");
            println!("This was {}", i)
        }
    }
}

• select the loop variable i
• Refactor / Rename, and rename to "name"
  => the resulting program is below, note that i was not renamed in println!("Hello, world! {i}").

fn main() {
    for name in ["One", "Two", "", "Last"] {
        if !name.is_empty() {
            println!("Hello, world! {i}");
            println!("This was {}", name)
        }
    }
}

The same problem occurs with normal 'let' variables and constants.

[rsalmei]

I think it is more than refactoring. I got warnings that variables are not used:

The same with the r in the last match arm... It is also "unused"...

And they are not highlighted:

Thanks!

[blueglyph]

Yes, I think that's for the same reason. The grammar used by the plugin (Java bytecode, whether from ANTLR, hand-crafted or LEX/YACC port) is unlikely from the same source as the compiler (written in Rust).

When RFC 2795 was implemented, it was probably not integrated into the plugin's grammar.

This issue must be linked to the issue: #7338

[blueglyph]

See also the pull request here (WIP): #8561 but I'm not sure there isn't more work to do for the refactoring once the grammar is fine.