Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RsMacroArgument should implement PsiLanguageInjectionHost #9943

Closed
lppedd opened this issue Jan 5, 2023 · 1 comment · Fixed by #9974
Closed

RsMacroArgument should implement PsiLanguageInjectionHost #9943

lppedd opened this issue Jan 5, 2023 · 1 comment · Fixed by #9974
Assignees
Labels
feature subsystem::language injection Issues related to injection one languages into another one subsystem::macros Issues related to macros

Comments

@lppedd
Copy link

lppedd commented Jan 5, 2023

The pre-requisite for injection availability is the macro must accept a TokenStream.

This will allow IntelliLang to automatically propose injection of different languages.
A typical use case might be injecting the Pomsky language to which I'm adding support in IDEA.

At the moment I'm implementing my own injection, which is a lot of work.
So if we can have it in the language itself, it's better.

cc @Aloso

@neonaot neonaot added feature subsystem::macros Issues related to macros labels Jan 5, 2023
@lppedd
Copy link
Author

lppedd commented Jan 5, 2023

Beware that currently RsMacroArgument include parenthesis too.

Maybe a strip trailing whitespace filter is also required, or it can be delegated to third parties.

@vlad20012 vlad20012 added the subsystem::language injection Issues related to injection one languages into another one label Jan 13, 2023
@bors bors bot closed this as completed in 39b71a4 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature subsystem::language injection Issues related to injection one languages into another one subsystem::macros Issues related to macros
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants