(MISC) Double Negation inspection #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Oct 5, 2016
| } | ||
| } | ||
|
|
||
| private fun isNegation(el: RustExprElement?) = |
There was a problem hiding this comment.
A possible alternative is an extension function on a nullable reciever:
private val RustExprElement?.isNegation: Boolean
get() = this is RustUnaryExprElement && minus != nullNote that this is RustUnaryExprElement implies that this != null.
There was a problem hiding this comment.
You're right, that looks better
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspection that is an analogue of Clippy's double_neg lint. Catches expressions of the form
--xwhich are no-op in Rust.