Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chance to change/reset the password of the account #1285

Closed
mlodic opened this issue Nov 10, 2022 · 7 comments
Closed

Add chance to change/reset the password of the account #1285

mlodic opened this issue Nov 10, 2022 · 7 comments
Assignees

Comments

@mlodic
Copy link
Member

mlodic commented Nov 10, 2022

We could add an additional section for the user where it is possible to change/reset their password. The "API access" section could be used for inspiration

@0x0elliot
Copy link
Member

0x0elliot commented Nov 19, 2022

do you want to make it so that the user has permission to do the same if they are logged in? or, do you want to make it so that there is a proper URL with a token sent to the user's email over this? honestly, that would be pretty cool and would definitely complete IntelOwl neatly and make it even more well-suited for deployment.

i am assuming that it is a mix of both.

@mlodic
Copy link
Member Author

mlodic commented Nov 19, 2022

yeah basically the issue that I notice is that there is neither chance for the user to change their password, nor to reset it in case they forget.

So they are 2 different but related problems.

The first can be solved by following my and your first suggestion, so when the user is already logged in.
The second would be solved with your last suggestion, when the user is not logged and can't get access.

Makes sense?

@mlodic mlodic closed this as completed Nov 19, 2022
@mlodic mlodic reopened this Nov 19, 2022
@0x0elliot
Copy link
Member

very much! would leave this issue open for the community to handle till i have the bandwidth for this one as well.

@mlodic
Copy link
Member Author

mlodic commented Mar 29, 2023

Password reset feature was added at time of addition of Registration page. Password change feature still needs to be added

@shivam-Purohit
Copy link
Contributor

@mlodic I have pushed some initial frontend changes to the authentication branch
I used the login component, suggest me some changes you want. I will try to align the component in the middle.
for the logic part I may try to use the same logic used for login to verify the old password and some registration logic to setup new
I have few doubts though

  • do we need the forgot password button( i think it would make sense to keep it there)
  • do we need email verification button

@mlodic
Copy link
Member Author

mlodic commented Jun 6, 2023

please open a draft PR with the changes.

About the doubts: those 2 features are already implemented and those buttons are already available in the Login Page. Here we need to provide the users the chance to change their password if they remember it while they have been logged.

@shivam-Purohit
Copy link
Contributor

About the doubts: those 2 features are already implemented and those buttons are already available in the Login Page. Here we need to provide the users the chance to change their password if they remember it while they have been logged.

My bad. I thought about it then forgot. I will remove the buttons

@mlodic mlodic closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants