Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Metric names seem inconsistent compared to other plugins #19

Closed
obourdon opened this issue Aug 23, 2016 · 1 comment
Closed

Metric names seem inconsistent compared to other plugins #19

obourdon opened this issue Aug 23, 2016 · 1 comment

Comments

@obourdon
Copy link

obourdon commented Aug 23, 2016

When looking at the current set of metrics exposed on a system, we get:

/intel/disk/<DISK>/smart/availablereservedspace
/intel/disk/<DISK>/smart/availablereservedspace/normalized
/intel/disk/<DISK>/smart/casetemperature
/intel/disk/<DISK>/smart/casetemperature/max
/intel/disk/<DISK>/smart/casetemperature/min
/intel/disk/<DISK>/smart/casetemperature/normalized
/intel/disk/<DISK>/smart/casetemperature/overcounter
/intel/disk/<DISK>/smart/crcerrors
/intel/disk/<DISK>/smart/crcerrors/normalized
/intel/disk/<DISK>/smart/e2eerrors
/intel/disk/<DISK>/smart/e2eerrors/normalized
/intel/disk/<DISK>/smart/erasefailcount
/intel/disk/<DISK>/smart/erasefailcount/normalized
/intel/disk/<DISK>/smart/hostwrites
/intel/disk/<DISK>/smart/hostwrites/normalized
/intel/disk/<DISK>/smart/internaltemperature
/intel/disk/<DISK>/smart/internaltemperature/normalized
/intel/disk/<DISK>/smart/pendingsectors
/intel/disk/<DISK>/smart/pendingsectors/normalized
/intel/disk/<DISK>/smart/powercyclecount
/intel/disk/<DISK>/smart/powercyclecount/normalized
/intel/disk/<DISK>/smart/powerlossprotectionfailure
/intel/disk/<DISK>/smart/powerlossprotectionfailure/normalized
/intel/disk/<DISK>/smart/powerlossprotectionfailure/sincelast
/intel/disk/<DISK>/smart/powerlossprotectionfailure/tests
/intel/disk/<DISK>/smart/poweronhours
/intel/disk/<DISK>/smart/poweronhours/normalized
/intel/disk/<DISK>/smart/programfailcount
/intel/disk/<DISK>/smart/programfailcount/normalized
/intel/disk/<DISK>/smart/reallocatedsectors
/intel/disk/<DISK>/smart/reallocatedsectors/normalized
/intel/disk/<DISK>/smart/reservedblocks
/intel/disk/<DISK>/smart/reservedblocks/normalized
/intel/disk/<DISK>/smart/satadownshifts
/intel/disk/<DISK>/smart/satadownshifts/normalized
/intel/disk/<DISK>/smart/thermalthrottle
/intel/disk/<DISK>/smart/thermalthrottle/eventcount
/intel/disk/<DISK>/smart/thermalthrottle/normalized
/intel/disk/<DISK>/smart/timedworkload/mediawear
/intel/disk/<DISK>/smart/timedworkload/mediawear/normalized
/intel/disk/<DISK>/smart/timedworkload/readpercent
/intel/disk/<DISK>/smart/timedworkload/readpercent/normalized
/intel/disk/<DISK>/smart/timedworkload/time
/intel/disk/<DISK>/smart/timedworkload/time/normalized
/intel/disk/<DISK>/smart/totallba/read
/intel/disk/<DISK>/smart/totallba/read/normalized
/intel/disk/<DISK>/smart/totallba/written
/intel/disk/<DISK>/smart/totallba/written/normalized
/intel/disk/<DISK>/smart/uncorrectableerrors
/intel/disk/<DISK>/smart/uncorrectableerrors/normalized
/intel/disk/<DISK>/smart/unexpectedpowerloss
/intel/disk/<DISK>/smart/unexpectedpowerloss/normalized
/intel/disk/<DISK>/smart/unsafeshutdowns
/intel/disk/<DISK>/smart/unsafeshutdowns/normalized
/intel/disk/<DISK>/smart/wearout
/intel/disk/<DISK>/smart/wearout/normalized

Wouldn't it be more coherent to have:

  1. /intel/disk/smart/ as the prefix (exchange rank of smart and in namespace and add /device/ intermediate element)
  2. remove all other extra levels to keep only a 5 levels namespace and rewrite metrics like
...
/intel/disk/smart/device/<DISK>/total_lba_read
/intel/disk/smart/device/<DISK>/total_lba_read_normalized
/intel/disk/smart/device/<DISK>/total_lba_written
/intel/disk/smart/device/<DISK>/total_lba_written_normalized
...
/intel/disk/smart/device/<DISK>/unsafe_shutdowns
/intel/disk/smart/device/<DISK>/unsafe_shutdowns_normalized
...

Thanks for your comments

@katarzyna-z
Copy link
Contributor

Resolved by #25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants