Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Release 0.4.1 with RxSwift extension. Resolves #2 #9

Merged
merged 3 commits into from Dec 20, 2017

Conversation

alexruperez
Copy link
Contributor

@alexruperez alexruperez commented Dec 19, 2017

Issue Link 🔗

#2

Goals ⚽

Create a RxSwift extension for NetClient

Implementation Details 🚧

NetTask rx extension


This change is Reviewable

@alexruperez alexruperez self-assigned this Dec 19, 2017
@alexruperez alexruperez added this to the 0.4.1 milestone Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #9 into master will decrease coverage by 2.71%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #9      +/-   ##
=========================================
- Coverage    5.16%   2.45%   -2.72%     
=========================================
  Files          82     222     +140     
  Lines        7537   15870    +8333     
  Branches       72      72              
=========================================
  Hits          389     389              
- Misses       7146   15479    +8333     
  Partials        2       2
Impacted Files Coverage Δ
...ds/RxSwift/RxSwift/Observables/Dematerialize.swift 0% <0%> (ø)
Pods/RxSwift/RxSwift/Observable.swift 0% <0%> (ø)
.../RxSwift/Schedulers/VirtualTimeConverterType.swift 0% <0%> (ø)
...ods/RxSwift/RxSwift/Traits/PrimitiveSequence.swift 0% <0%> (ø)
Pods/RxSwift/RxSwift/Observables/ElementAt.swift 0% <0%> (ø)
Pods/RxSwift/RxSwift/Observables/Sink.swift 0% <0%> (ø)
...RxSwift/RxSwift/Disposables/SerialDisposable.swift 0% <0%> (ø)
...ft/RxSwift/Schedulers/Internal/ScheduledItem.swift 0% <0%> (ø)
...Swift/RxSwift/Disposables/RefCountDisposable.swift 0% <0%> (ø)
...xSwift/RxSwift/Observables/DelaySubscription.swift 0% <0%> (ø)
... and 276 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c3cbf...50a89d7. Read the comment docs.

@juantrias
Copy link

:lgtm_strong: Now it's time to play with it!


Reviewed 225 of 228 files at r1, 9 of 10 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


RxSwift/NetTask+Rx.swift, line 37 at r2 (raw file):

            })
            return Disposables.create()
        }

Veo que en RxAlamofire han añadido un .startWith(RxProgress(bytesWritten: 0, totalBytes: 0)) Sería necesario aquí o el callback de self.base.progress empieza a ejecutarse nada más lanzar la petición?


Comments from Reviewable

@alexruperez
Copy link
Contributor Author

@juantrias empieza solo al lanzar, confirmado. :)

@alexruperez alexruperez merged commit 7256605 into master Dec 20, 2017
@alexruperez alexruperez deleted the #2-RxNetClient branch December 20, 2017 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants