Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed import of MWLayoutHelpers in INKDefaultsCell and INKAppIconView and duplicate symbols for ink_urlEncode #66

Merged
merged 3 commits into from Mar 3, 2016

Conversation

patrickkempff
Copy link
Contributor

Fixed import of MWLayoutHelpers in INKAppIconView.m and INKDefaultsCell.m,
Other files with this import are already fixed.

Also fixed compiler error: duplicate symbols for ink_urlEncode

lazerwalker added a commit that referenced this pull request Mar 3, 2016
Fixed import of MWLayoutHelpers in INKDefaultsCell and INKAppIconView and duplicate symbols for ink_urlEncode
@lazerwalker lazerwalker merged commit 869ed84 into intentkit:master Mar 3, 2016
@lazerwalker
Copy link
Member

Ah, awesome. Thanks for this, and thanks also for the Travis fix!

@mtage70
Copy link

mtage70 commented May 27, 2016

Hey @patrickkempff and/or @lazerwalker I'm getting linker command failures when using your pod in Cocoapods version 1.0.0, "duplicate symbol _ink_urlEncode". Might be an issue on my end but other pods appear to be working fine with the update. I'm using IntentKit/Maps 0.7.2 and it was working fine on Cocoapods version 0.39.0. Let me know if you'll need any more info about this.

@lazerwalker
Copy link
Member

@mtage70 this should be fixed on master, but a new version hasn't been released to Cocoapods yet.

If you manually point the pod to master of this repo it should work, but I'm also hoping I'll have the time to cut a new proper Cocoapods release tomorrow (see #63)

@lazerwalker
Copy link
Member

My current net access doesn't seem fast enough to want to let me push a new version to Cocoapods trunk, but if you try manually setting your Podfile to this git repo with a tag of 0.7.3, that should work for you. Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants