Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reimplement manual sharding/presence, fix forum tag implementation #1115

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Oct 9, 2022

About

This pull request reimplements manual sharding/presence from Client args, which may have been accidentally removed in ~#1022.
This PR also refactors forum tag http implementation to account for cache, a new tag attribute + non-deprecated endpoint.
(This was broken prior because of cache and how the API handles tag editing, primarily)

(minor out of scope related PR but /shrug)

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

(This was accidentally removed per gateway rework)
@FayeDel FayeDel added the enhancement New feature or request label Oct 9, 2022
@FayeDel FayeDel self-assigned this Oct 9, 2022
@EdVraz EdVraz enabled auto-merge (squash) October 9, 2022 14:51
@EdVraz EdVraz merged commit 7394cd6 into interactions-py:unstable Oct 9, 2022
Copy link
Contributor

@EdVraz EdVraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

FayeDel added a commit that referenced this pull request Oct 9, 2022
* feat: Implement helper methods for invites (#1098)

* feat: mention spam trigger type

* fix: Reimplement manual sharding/presence, fix forum tag implementation (#1115)

* fix: Reimplement manual sharding/presence instantiation.

(This was accidentally removed per gateway rework)

* refactor: Reorganise tag creation/updating/deletion to non-deprecated endpoints and make it cache-reflective.

* chore: bump version (#1116)

* fix: properly initialise private attributes in iterators (#1114)

* fix: set `message.member.user` as `message.author` again (#1118)

Co-authored-by: Damego <danyabatueff@gmail.com>
Co-authored-by: i0 <41456914+i0bs@users.noreply.github.com>
Co-authored-by: DeltaX <33706469+DeltaXWizard@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants