New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gateway,component): SelectMenu parse per SelectOption #423
Conversation
@DeltaXWizard look at pr pls 👀 |
if context.data._json.get("values"): | ||
_args.append(context.data.values) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me,
but I want to know the reason behind the add values in message component
detail, over simply just using context object as how it was in v3's callbacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in the callback function it will be much easier to immediately receive the selected value than to request it from nowhere (I, for example, did not immediately understand that the value can be obtained from the context).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got a merge conflict
About
This pull request is about (X), which does (Y).
fix SelectMenu
add values in message_component
pre-commit
to format and lint the change(s) made.3.8.6
and higher.