New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make methods use the MISSING
value
#455
Conversation
- channel.py - channel.pyi
- guild.py - guild.pyi
- member.py - member.pyi
- message.py - message.pyi
- role.py - role.pyi
MISSING
valueMISSING
value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to comment on every single file needing the Optional
, but they should target the object that they need. For example, embeds
should be Optional[Union[Embed, List[Embed]]
and vice versa.
But i can't import it due to circular import And if I'd put it there without having it imported I'd not pass the pre-commit |
How are you hitting circular imports? |
Message is importing Channel and member, so I can't import Embed from Message ok, I'll do that |
I shouldn't forget to turn off that god damn autocorrect next time...
About
This pull request refactors methods to use the
MISSING
valueChecklist
pre-commit
to format and lint the change(s) made.3.8.6
and higher.