New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Minor parameter catching #463
Conversation
"description" in Option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an exception be raised for uppercase names, or should we convert to lower case and pass?
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
I would raise an exception because it is a bad practice when you are doing it the wrong way and we just pass it the way that it should be |
Also, please run pre-commit |
Pre-commit struggling server-side today |
the ubuntu check passes so it should be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving the appropriated use of the exception here. :)
Please run pre-commit
one last time.
|
About
Checklist
pre-commit
to format and lint the change(s) made.3.8.6
and higher.TypeError
will occur: