Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Abstract modify method in data models for simplified usage. #479

Merged
merged 5 commits into from Feb 21, 2022
Merged

feat: Abstract modify method in data models for simplified usage. #479

merged 5 commits into from Feb 21, 2022

Conversation

EdVraz
Copy link
Contributor

@EdVraz EdVraz commented Feb 6, 2022 •
edited

Allows the usage of

await channel.set_name("newname")

instead

await channel.modify(name="newname")

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EdVraz EdVraz added the enhancement New feature or request label Feb 6, 2022
@EdVraz EdVraz changed the title feat: Expand bigger helper methods into smaller methods feat: Expand "modify" helper methods into single-argument helper methods to make editing of only one field easier Feb 7, 2022
@EdVraz
Copy link
Contributor Author

EdVraz commented Feb 7, 2022

i won't include member and role because those actually require a guild_id

@EdVraz EdVraz marked this pull request as ready for review February 7, 2022 20:35
@EdVraz EdVraz requested a review from FayeDel February 7, 2022 20:35
@EdVraz EdVraz self-assigned this Feb 9, 2022
@EdVraz EdVraz linked an issue Feb 14, 2022 that may be closed by this pull request
[REQUEST] expand helper methods #472
Closed
@i0bs i0bs enabled auto-merge (squash) February 18, 2022 03:42
@i0bs i0bs changed the title feat: Expand "modify" helper methods into single-argument helper methods to make editing of only one field easier feat: Abstract modify method in data models for simplified usage. Feb 19, 2022
@i0bs i0bs merged commit 2811842 into interactions-py:unstable Feb 21, 2022
i0bs pushed a commit that referenced this pull request Feb 25, 2022
@EdVraz @i0bs
feat: Expand "modify" helper methods into single-argument helper meth…
6a86e98 
…ods to make editing of only one field easier (#479)

* channel.modify

* refactor: add `*`

* some guild stuff

* feat: expand guild.modify

* feat: expand guild.modify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i0bs i0bs i0bs approved these changes

@FayeDel FayeDel Awaiting requested review from FayeDel

Assignees

@EdVraz EdVraz

Labels
enhancement New feature or request
Projects
core
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] expand helper methods
2 participants
@EdVraz @i0bs