Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement ctx.custom_id and ctx.label properties #484

Merged
merged 3 commits into from Feb 7, 2022

Conversation

Jalancar
Copy link
Contributor

@Jalancar Jalancar commented Feb 7, 2022

About

This pull request is about adding custom_id and label properties to ComponentContext, which makes it easier to retrieve these commonly used values.

Checklist

@Jalancar
Copy link
Contributor Author

Jalancar commented Feb 7, 2022

Let me know if there are any other attributes anyone would want. I didn't include ctx.component since the idea is to have access to the info without needing it, or ctx.selected_options since that is passed to the callback already

Copy link
Contributor

@EdVraz EdVraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in #465 please use @property values.

@EdVraz EdVraz added the enhancement New feature or request label Feb 7, 2022
@Jalancar Jalancar changed the title feat: implement ctx.custom_id and ctx.label attributes feat: implement ctx.custom_id and ctx.label properties Feb 7, 2022
@Jalancar
Copy link
Contributor Author

Jalancar commented Feb 7, 2022

I changed them to properties, but I don't know how to mark your change request as completed (if I even can)

@Toricane
Copy link
Contributor

Toricane commented Feb 7, 2022

I changed them to properties, but I don't know how to mark your change request as completed (if I even can)

Press the rerequest button or something like that

@Jalancar Jalancar requested a review from EdVraz February 7, 2022 17:45
@Jalancar
Copy link
Contributor Author

Jalancar commented Feb 7, 2022

I changed them to properties, but I don't know how to mark your change request as completed (if I even can)

Press the rerequest button or something like that

Found it, thanks

@i0bs i0bs merged commit 1d87559 into interactions-py:unstable Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants