feat: Added User.avatar_url() to get the resulting URL from a user #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
FayeDel
reviewed
Feb 14, 2022
i0bs
previously requested changes
Feb 14, 2022
FayeDel
reviewed
Feb 15, 2022
|
will this conflict with bot.user at all? |
This does not conflict with bot.user/client.user (It just adds a property) Anyway, this looks good to me, I'm merging :) |
EdVraz
approved these changes
Feb 15, 2022
FayeDel
approved these changes
Feb 15, 2022
i0bs
approved these changes
Feb 18, 2022
i0bs
pushed a commit
that referenced
this pull request
Feb 25, 2022
) * feat: Added User.avatar_url() to get the resulting URL from a user * ci: correct from checks. * fix: Make the User.avatar_url a property * fix: remove useless import * fix: remove wrong headers Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: DeltaX <33706469+DeltaXWizard@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is about creating a
User.avatar_url()function, to return the proper User avatar URL.Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.