Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix _json parsing for non-existent Emoji argument #538

Merged
merged 3 commits into from Feb 18, 2022

Conversation

FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Feb 18, 2022

About

This pull request fixes the _json attribute when self.emoji is None.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@i0bs i0bs enabled auto-merge (squash) February 18, 2022 19:22
@i0bs i0bs merged commit 4dfda38 into interactions-py:unstable Feb 18, 2022
@i0bs i0bs linked an issue Feb 18, 2022 that may be closed by this pull request
4 tasks
@FayeDel FayeDel deleted the unstable_bug_1 branch February 18, 2022 20:53
i0bs pushed a commit that referenced this pull request Feb 25, 2022
* fix: Fix _json parsing for non-existent Emoji arguments

* ci: correct from checks.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

[BUG] SelectOption breaks if optional emoji not specified
3 participants