Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix!: prevent conflict between slot and function name in guild.py #556

Merged
merged 2 commits into from Feb 21, 2022
Merged

Fix!: prevent conflict between slot and function name in guild.py #556

merged 2 commits into from Feb 21, 2022

Conversation

EdVraz
Copy link
Contributor

@EdVraz EdVraz commented Feb 21, 2022

About

This pull request is about (X), which does (Y).

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EdVraz EdVraz changed the title Update guild.py Fix!: prevent conflict between slot and function name in guild.py Feb 21, 2022
@EdVraz EdVraz enabled auto-merge (squash) February 21, 2022 23:12
@EdVraz EdVraz added bug Something isn't working breaking This contains breaking changes labels Feb 21, 2022
@EdVraz EdVraz requested a review from FayeDel February 21, 2022 23:12
FayeDel
FayeDel requested changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@FayeDel FayeDel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it as well in the headers.

@EdVraz EdVraz requested a review from FayeDel February 21, 2022 23:20
FayeDel
FayeDel approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@FayeDel FayeDel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@EdVraz EdVraz merged commit 38b3dba into unstable Feb 21, 2022
@EdVraz EdVraz deleted the EdVraz-patch-1 branch February 22, 2022 06:11
i0bs pushed a commit that referenced this pull request Feb 25, 2022
@EdVraz @i0bs
Fix!: prevent conflict between slot and function name in guild.py (#556)
b07637f 
* Update guild.py

* Update guild.pyi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FayeDel FayeDel FayeDel approved these changes

Assignees
No one assigned
Labels
breaking This contains breaking changes bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EdVraz @FayeDel