fix!: Correct gateway command and subcommand dispatching #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdVraz
added
bug
i0bs
approved these changes
Feb 24, 2022
i0bs
added a commit
that referenced
this pull request
Feb 25, 2022
* fix!: correct kwarg dictionary when dispatching a command * undo changes in dispatch * fix!: argument conversion for non-sub-commands * fix!: sub-command keyerror * fix!: _client for attributes and sub_command(_group) convertion * Update headers * Update gateway.py * fix!: add _client to slots * style: rename dunder Co-authored-by: fl0w <41456914+goverfl0w@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull requests corrects the returned objects in the command dispatch, adds _client to them and sets the kwargs for sub_command and sub_command_groups correctly
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.