Fix!: prevent NoneType error during sub command checks and add kwarg for sub_commands without options
#568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdVraz
changed the title
NoneType error during sub command checksNoneType error during sub command checks and add kwarg for sub_commands without options
1 task
1 task
|
LGTM (tested against options bug) |
FayeDel
approved these changes
Feb 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
See https://discord.com/channels/789032594456576001/946655656092524584/946655661213749249
also fixes an error where sub_command would not be dispatched if it had no options
also adds _client to the Attachment object to prevent an AttributeError
Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.