Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guild, channel): implement new helper methods #600

Merged
merged 20 commits into from Mar 20, 2022
Merged

feat(guild, channel): implement new helper methods #600

merged 20 commits into from Mar 20, 2022

Conversation

EdVraz
Copy link
Contributor

@EdVraz EdVraz commented Mar 1, 2022

Checklist

@EdVraz EdVraz added the documentation Improvements or additions to documentation label Mar 1, 2022
@EdVraz EdVraz self-assigned this Mar 1, 2022
@EdVraz EdVraz linked an issue Mar 1, 2022 that may be closed by this pull request
@EdVraz
Copy link
Contributor Author

EdVraz commented Mar 1, 2022

keeping this as draft until other PRs of me are merged since they're all from the same base branch bruh

@EdVraz EdVraz marked this pull request as ready for review March 1, 2022 20:10
@EdVraz EdVraz changed the title feat: implement new helper methods for invites (and a few more) feat(guild, channel): implement new helper methods Mar 1, 2022
@EdVraz EdVraz enabled auto-merge (squash) March 1, 2022 22:59
Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the get classmethods if we're eventually going for a dynamic solution in the client?

@EdVraz
Copy link
Contributor Author

EdVraz commented Mar 13, 2022

Well, we don't "need" them but I figured it would be nice if they existed atleast until that method

@i0bs
Copy link
Contributor

i0bs commented Mar 13, 2022

My feelings on the existence of get being here is similar to #470 in which we want a more dynamic solution to it without having to hardcode it per data model, as well as it'll be done when it's addressed.

@EdVraz EdVraz requested review from i0bs March 20, 2022 19:32
@EdVraz
Copy link
Contributor Author

EdVraz commented Mar 20, 2022

The get methods are removed; merge conflicts corrected

@EdVraz EdVraz merged commit e0cbb8a into interactions-py:unstable Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

[REQUEST] implement channel invite and channel.get classmethod
2 participants