Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent kwargs modification during for loop iteration #685

Merged
merged 1 commit into from Mar 29, 2022
Merged

fix: prevent kwargs modification during for loop iteration #685

merged 1 commit into from Mar 29, 2022

Conversation

V3ntus
Copy link
Contributor

@V3ntus V3ntus commented Mar 29, 2022 •
edited

About

Creates a protected instance of kwargs during the DictSerializerMixin for for loop to prevent RuntimeError

Checklist

@EdVraz
Copy link
Contributor

EdVraz commented Mar 29, 2022

Please test it

@V3ntus
Copy link
Contributor Author

V3ntus commented Mar 29, 2022

@EdVraz Well I'm not getting RuntimeError now after this. Tested

@V3ntus V3ntus marked this pull request as ready for review March 29, 2022 20:10
@EdVraz EdVraz enabled auto-merge (squash) March 29, 2022 20:20
EdVraz
EdVraz approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@EdVraz EdVraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdVraz EdVraz merged commit 556b387 into interactions-py:unstable Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdVraz EdVraz EdVraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@V3ntus @EdVraz