New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Localisation support. #686
Conversation
chore: release 4.1.0
* docs: add migration docs for 4.1 * docs: detail message content intent in migration
…ctions-py#574) * docs: add migration docs for 4.1 * docs: detail message content intent in migration
chore: pre-release 4.1.1-beta.1
chore!: pre-release 4.1.1-beta.2
…commands, implement Locale enum.
…ting, refactored decor.py
… type conversion safeguard for Locale usage.
...I like this PR in general, but it's kind of odd. Shouldn't these be broken up into separate commits? That would be much clearer when scrolling back through the commit history. |
I agree on that, I was thinking the same before |
Yeah, it's weird for "localization support" to have bug fixes out of all things. |
Yeah this PR wasn't meant to be squashed, rather merged/rebased. (But also, I wasn't sure what else to title it 🤷🏻♀️) |
That's fine and all and the commit history itself is very clean... but this should really be separated regardless of the merge strategy. It's near impossible to test everything and ensure everything is working fine, and also makes digging through PRs to find what is introduced harder. IMO there's absolutely no reason this shouldn't be closed and separated into various PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to look good, I can't see anything bad in the latest commits
…ctor HTTP remaining logic checking,
About
This mega PR:
application/json
header correctly.timestamp
instantiation on the Embed object.GET /guilds/{guild.id}/bans
.Checklist
pre-commit
to format and lint the change(s) made.3.8.6
and higher.timestamp
being added to Embeds at HTTP POST response #684