Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix remaining variable definition. #696

Merged
merged 2 commits into from Apr 3, 2022
Merged

fix: Fix remaining variable definition. #696

merged 2 commits into from Apr 3, 2022

Conversation

FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Apr 2, 2022

About

This bug fix simply rechecks if the remaining variable is None.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@FayeDel FayeDel added the bug Something isn't working label Apr 2, 2022
i0bs
i0bs suggested changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use and operation

@FayeDel FayeDel enabled auto-merge (squash) April 2, 2022 23:59
@FayeDel FayeDel mentioned this pull request Apr 3, 2022
Merged
8 tasks
@FayeDel FayeDel requested a review from EdVraz April 3, 2022 14:20
@EdVraz
Copy link
Contributor

EdVraz commented Apr 3, 2022

@goverfl0w has to approve since he requested changes

@i0bs
Copy link
Contributor

i0bs commented Apr 3, 2022

All good now, force merge if needed since github mobile is being a cock.

(Request review from me Austin next time too please!)

@FayeDel FayeDel requested a review from i0bs April 3, 2022 14:30
@FayeDel FayeDel merged commit e391492 into interactions-py:unstable Apr 3, 2022
@FayeDel FayeDel deleted the unstable_core_3 branch April 9, 2022 17:25
@FayeDel FayeDel restored the unstable_core_3 branch April 9, 2022 17:25
@FayeDel FayeDel deleted the unstable_core_3 branch April 9, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i0bs i0bs i0bs approved these changes

@EdVraz EdVraz EdVraz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FayeDel @EdVraz @i0bs