Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Refix context resolution due to architecture change. #697

Merged
merged 3 commits into from Apr 3, 2022

Conversation

FayeDel
Copy link
Collaborator

@FayeDel FayeDel commented Apr 3, 2022

About

This pull request fixes context importing due to a architectural fix implemented in 9ce0568.

This is also tested alongside #696, as that aforementioned PR fixes on_boot and this on_command.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@FayeDel FayeDel added the bug Something isn't working label Apr 3, 2022
@EdVraz
Copy link
Contributor

EdVraz commented Apr 3, 2022

Pre commit fails

@FayeDel
Copy link
Collaborator Author

FayeDel commented Apr 3, 2022

Pre-commit fails not because of this library, that's a CI problem.
Locally, pre-commit passes all checks.

@EdVraz
Copy link
Contributor

EdVraz commented Apr 3, 2022

It says import error

@FayeDel FayeDel merged commit b477c95 into interactions-py:unstable Apr 3, 2022
@FayeDel FayeDel deleted the unstable_core_5 branch April 9, 2022 17:25
@FayeDel FayeDel restored the unstable_core_5 branch April 9, 2022 17:25
@FayeDel FayeDel deleted the unstable_core_5 branch April 9, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants