Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more image URL helpers #699

Merged
merged 12 commits into from Apr 5, 2022
Merged

feat: Add more image URL helpers #699

merged 12 commits into from Apr 5, 2022

Conversation

mAxYoLo01
Copy link
Contributor

About

This PR's goal is to implement more image URL helpers:

  • Guild banner, invite splash and discovery splash
  • User banner
  • Member avatar (by specifying for which guild)

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@mAxYoLo01
Copy link
Contributor Author

Don't mind the double commits, looks like I don't know how to rebase lmfao

@i0bs i0bs added enhancement New feature or request documentation Improvements or additions to documentation labels Apr 5, 2022
@i0bs i0bs changed the title Feat: Add more image URL helpers feat: Add more image URL helpers Apr 5, 2022
@i0bs i0bs enabled auto-merge (squash) April 5, 2022 00:36
i0bs
i0bs approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@i0bs i0bs merged commit ab0e036 into interactions-py:unstable Apr 5, 2022
@mAxYoLo01 mAxYoLo01 deleted the image_formatting branch April 5, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i0bs i0bs i0bs approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
core
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mAxYoLo01 @i0bs