Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to suppress embeds on message edit #774

Merged
merged 5 commits into from May 19, 2022
Merged

feat: ability to suppress embeds on message edit #774

merged 5 commits into from May 19, 2022

Conversation

Toricane
Copy link
Contributor

@Toricane Toricane commented May 3, 2022

About

This pull request is about implementing SUPPRESS_EMBEDS in Message.edit(), which lets you suppress or unsuppress embeds when editing a message.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@FayeDel FayeDel added documentation Improvements or additions to documentation enhancement New feature or request labels May 3, 2022
EdVraz
EdVraz suggested changes May 8, 2022
View reviewed changes
interactions/api/models/message.py Outdated Show resolved Hide resolved
interactions/api/models/message.py Outdated Show resolved Hide resolved
@AstreaTSS AstreaTSS added the on hold This issue/PR is on hold pending higher priority issues/PRs label May 9, 2022
Toricane and others added 2 commits May 10, 2022 18:06
@Toricane @EdVraz
Update interactions/api/models/message.py
87a0e10 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Toricane @EdVraz
Update interactions/api/models/message.py
cb01585 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Toricane Toricane requested a review from EdVraz May 11, 2022 01:42
@Toricane Toricane removed the on hold This issue/PR is on hold pending higher priority issues/PRs label May 14, 2022
@Toricane Toricane enabled auto-merge (squash) May 14, 2022 21:18
@Toricane Toricane merged commit 903c406 into interactions-py:unstable May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdVraz EdVraz EdVraz approved these changes

@AstreaTSS AstreaTSS Awaiting requested review from AstreaTSS

@FayeDel FayeDel Awaiting requested review from FayeDel

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Toricane @EdVraz @AstreaTSS @FayeDel