Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix incorrect type note for Overwrite id #811

Merged
merged 1 commit into from Jun 2, 2022
Merged

docs: fix incorrect type note for Overwrite id #811

merged 1 commit into from Jun 2, 2022

Conversation

AstreaTSS
Copy link
Member

About

Overwrite's id was incorrectly noted as an integer. In reality, it's a string. This PR just fixes the note about it to note that.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@AstreaTSS AstreaTSS added the documentation Improvements or additions to documentation label Jun 2, 2022
Toricane
Toricane approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Toricane Toricane merged commit 86fe656 into interactions-py:unstable Jun 2, 2022
@AstreaTSS AstreaTSS deleted the overwrite-fix branch June 8, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toricane Toricane Toricane approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AstreaTSS @Toricane