Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Improve DX with allowing the usage of the actual object additionally to the ID #828

Merged
merged 13 commits into from Jun 12, 2022
Merged

refactor!: Improve DX with allowing the usage of the actual object additionally to the ID #828

merged 13 commits into from Jun 12, 2022

Conversation

EdVraz
Copy link
Contributor

@EdVraz EdVraz commented Jun 8, 2022

About

This PR allows setting the full object instead of only its ID into helper methods

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EdVraz EdVraz added enhancement New feature or request breaking This contains breaking changes labels Jun 8, 2022
@EdVraz EdVraz marked this pull request as ready for review June 9, 2022 10:26
@EdVraz EdVraz enabled auto-merge (squash) June 9, 2022 10:26
Toricane
Toricane approved these changes Jun 12, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EdVraz EdVraz merged commit 0ce7736 into interactions-py:unstable Jun 12, 2022
@EdVraz EdVraz deleted the optimise_helper_methods branch June 12, 2022 19:14
Toricane added a commit that referenced this pull request Jun 12, 2022
@Toricane
docs: fix rtd build that broke in #828 (#849)
efb8d0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toricane Toricane Toricane approved these changes

@Catalyst4222 Catalyst4222 Awaiting requested review from Catalyst4222

@AstreaTSS AstreaTSS Awaiting requested review from AstreaTSS

@FayeDel FayeDel Awaiting requested review from FayeDel

Assignees
No one assigned
Labels
breaking This contains breaking changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EdVraz @Toricane