Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse sub cmd (and groups) options properly #835

Merged
merged 3 commits into from Jun 9, 2022
Merged

fix: parse sub cmd (and groups) options properly #835

merged 3 commits into from Jun 9, 2022

Conversation

AstreaTSS
Copy link
Member

About

This PR adjusts the option conversion logic for subcommands so that it handles both the Option object and the dict way. This method also adjusts the checks so that they use the resulting object, since it already has been converted.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EdVraz EdVraz changed the title fix: parse cub cmd (and groups) options properly fix: parse sub cmd (and groups) options properly Jun 9, 2022
@EdVraz EdVraz enabled auto-merge (squash) June 9, 2022 15:58
@EdVraz EdVraz merged commit 76da7bb into interactions-py:unstable Jun 9, 2022
@AstreaTSS AstreaTSS deleted the sub-cmd-fix branch June 11, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdVraz EdVraz EdVraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AstreaTSS @EdVraz