Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use input for timestamp if datetime #845

Merged
merged 1 commit into from Jun 12, 2022

Conversation

AstreaTSS
Copy link
Member

About

This PR allows for timestamp in Embed to use a datetime if it's provided one. This also modifies convert_type to make this possible, allowing the use of classmethods, but that's more of a happy accident with how this fix worked out.

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@EdVraz EdVraz enabled auto-merge (squash) June 12, 2022 10:23
@EdVraz EdVraz merged commit 5a8378c into interactions-py:unstable Jun 12, 2022
@AstreaTSS AstreaTSS deleted the timestamp-fix branch June 13, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants