Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make get_role more consistent #865

Merged
merged 15 commits into from Jun 18, 2022
Merged

refactor: make get_role more consistent #865

merged 15 commits into from Jun 18, 2022

Conversation

EdVraz
Copy link
Contributor

@EdVraz EdVraz commented Jun 17, 2022

About

This pull request is about (X), which does (Y).

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

i0bs and others added 13 commits April 5, 2022 15:02
chore!: pre-release for 4.1.1-rc.1
This file was actually cloned outside of the client directory in a PR that had not appropriately adjusted to the new architectural layout of the library.
This is an executive decision made between Delta and I. We will be forcing a version 4.0 push onto our old branch to help transition old users using v3 to our new project. This does not necessarily mean this branch will now be receiving updates along with the rest. The goal is to make our current branch used as much as possible.
@EdVraz EdVraz enabled auto-merge (squash) June 17, 2022 23:58
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extremely tiny thing

interactions/api/models/guild.py Outdated Show resolved Hide resolved
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
@EdVraz EdVraz requested a review from Toricane June 18, 2022 00:03
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing, i swear this is the last one

interactions/api/models/guild.py Outdated Show resolved Hide resolved
Co-authored-by: Toricane <73972068+Toricane@users.noreply.github.com>
@EdVraz EdVraz requested a review from Toricane June 18, 2022 00:13
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EdVraz EdVraz merged commit d4b7e09 into interactions-py:unstable Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants