Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create and implement IDMixin to compare/hash models that have ids #883

Merged
merged 2 commits into from Jun 28, 2022
Merged

feat: create and implement IDMixin to compare/hash models that have ids #883

merged 2 commits into from Jun 28, 2022

Conversation

Catalyst4222
Copy link
Contributor

About

What it says on the tin

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent): 534
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

@Catalyst4222 Catalyst4222 changed the base branch from stable to unstable June 26, 2022 04:37
@EdVraz
Copy link
Contributor

EdVraz commented Jun 26, 2022

Pre commit check fails

@Catalyst4222
Copy link
Contributor Author

Pre commit check fails

That's because I had to change the target branch, and the check didn't re-run

@Catalyst4222 Catalyst4222 requested a review from EdVraz June 27, 2022 00:18
@EdVraz EdVraz merged commit 37bbcb7 into interactions-py:unstable Jun 28, 2022
@Catalyst4222 Catalyst4222 deleted the unstable branch June 30, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdVraz EdVraz EdVraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Catalyst4222 @EdVraz