Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge enhanced #895

Merged
merged 63 commits into from Jul 11, 2022
Merged

feat: merge enhanced #895

merged 63 commits into from Jul 11, 2022

Conversation

Toricane
Copy link
Contributor

@Toricane Toricane commented Jun 28, 2022

About

This pull request merges most of the features from the enhanced ext.
I am aiming for no breaking changes.
This will be a draft until I am finished merging the features and the documentation.

Things that are added:

  1. A Command object, simplifying command decorators
  2. Subcommand system in the Command object
  3. default_scope key word argument in Client, letting you set a default scope for all commands (except those you disable)
  4. @option() decorator that adds options to commands in a single line
  5. Utilities such as:
    • @autodefer() decorator that automatically defers the command if delay is exceeded
    • spread_to_rows() helper function that spreads components into a list of ActionRows automatically
  6. A new way of creating an ActionRow (pun intended)
  7. Command.error decorator allowing a callback coroutine when a command errors

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

There are still countless TODOs, this is a progress commit
@Toricane Toricane added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 28, 2022
@Toricane Toricane marked this pull request as ready for review June 28, 2022 22:27
@Toricane
Copy link
Contributor Author

Toricane commented Jun 28, 2022

Wait what I didnt mark it ready for review, how did that happen
how do I make it a draft again
done

@Toricane Toricane marked this pull request as draft June 28, 2022 22:30
@EdVraz
Copy link
Contributor

EdVraz commented Jun 28, 2022

Wait what I didnt mark it ready for review, how did that happen
how do I make it a draft again
done

Could've been me, idk maybe the app did some shit because of my bad network

@Toricane Toricane self-assigned this Jun 30, 2022
@Toricane Toricane marked this pull request as ready for review July 11, 2022 01:48
@Toricane
Copy link
Contributor Author

Ready for review!

Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the new design changes to migrations.rst as well as clarification on that page for other features.

docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Outdated Show resolved Hide resolved
@Toricane
Copy link
Contributor Author

Oh I forgot about that, thanks
Should I keep it in the quickstart and add the migration in migration.rst, or remove it from quickstart.rst and move it to migration.rst?

@i0bs
Copy link
Contributor

i0bs commented Jul 11, 2022

Oh I forgot about that, thanks Should I keep it in the quickstart and add the migration in migration.rst, or remove it from quickstart.rst and move it to migration.rst?

Migration details should only be present in migration. However, if you're trying to show alternative methods, that is fine without the need to mention a specific version.

@Toricane Toricane requested a review from i0bs July 11, 2022 02:42
Copy link
Contributor

@EdVraz EdVraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think

@i0bs i0bs enabled auto-merge (squash) July 11, 2022 22:21
@i0bs i0bs merged commit 9cd8378 into interactions-py:unstable Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants