New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge enhanced #895
feat: merge enhanced #895
Conversation
There are still countless TODOs, this is a progress commit
Wait what I didnt mark it ready for review, how did that happen |
Could've been me, idk maybe the app did some shit because of my bad network |
btw i havent tested any of these
I still haven't tested these btw
Have not made it work in extensions yet
Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the new design changes to migrations.rst
as well as clarification on that page for other features.
Oh I forgot about that, thanks |
Migration details should only be present in migration. However, if you're trying to show alternative methods, that is fine without the need to mention a specific version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think
About
This pull request merges most of the features from the
enhanced
ext.I am aiming for no breaking changes.
This will be a draft until I am finished merging the features and the documentation.
Things that are added:
Command
object, simplifying command decoratorsCommand
objectdefault_scope
key word argument inClient
, letting you set a default scope for all commands (except those you disable)@option()
decorator that adds options to commands in a single line@autodefer()
decorator that automatically defers the command ifdelay
is exceededspread_to_rows()
helper function that spreads components into a list ofActionRow
s automaticallyActionRow
(pun intended)Command.error
decorator allowing a callback coroutine when a command errorsChecklist
pre-commit
to format and lint the change(s) made.3.8.6
and higher.