Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missed logic to Embed.insert_field_at #951

Merged
merged 3 commits into from Jul 22, 2022
Merged

fix: add missed logic to Embed.insert_field_at #951

merged 3 commits into from Jul 22, 2022

Conversation

Damego
Copy link
Member

@Damego Damego commented Jul 21, 2022 •
edited

About

Adds missed logic to Embed.insert_field_at and makes name and value are required

Checklist

  • I've ran pre-commit to format and lint the change(s) made.
  • I've checked to make sure the change(s) work on 3.8.6 and higher.
  • This fixes/solves an Issue.
    • (If existent):
  • I've made this pull request for/as: (check all that apply)
    • Documentation
    • Breaking change
    • New feature/enhancement
    • Bugfix

Toricane
Toricane suggested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion

interactions/api/models/message.py Show resolved Hide resolved
Toricane
Toricane approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Toricane Toricane merged commit 56df1a8 into interactions-py:unstable Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toricane Toricane Toricane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Damego @Toricane