Non pk session #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andyjack
commented
Jul 29, 2014
andyjack
commented
- Fix a bug in _retrieve, using the configured session data column name instead of ->session_data always 8a90fc5
- session_id column works now if it is not the primary key; column at least needs a unique constraint 9d353c8
- tests and docs (f57ada7, 76f7d95)
- in cases where session_id is not the PK of the table - session_id should still have a unique constraint
... not ->session_data which is incorrect when not using the default config
|
I've added a fix to _destroy so the session is ->find()'ed correctly before deletion. |
|
Sorry for the late merge. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.