Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final name of GroupPricing/Pricing #122

Closed
racke opened this issue Oct 31, 2014 · 4 comments
Closed

Final name of GroupPricing/Pricing #122

racke opened this issue Oct 31, 2014 · 4 comments
Assignees
@hexfusion
Labels
question
Milestone
Candy and name cl...

Comments

@racke
Copy link
Member

racke commented Oct 31, 2014

We aren't satisfied with the old name or current name of this class. The latest idea is to use "PriceModifiers" which is supported by @SysPete, @sbatschelet and myself.
@racke racke added the question label Oct 31, 2014
@racke racke added this to the Candy and name cleanup milestone Oct 31, 2014
@hexfusion hexfusion self-assigned this Oct 31, 2014
@hexfusion
Copy link
Contributor

This will remain open for comment till noon Monday 11/3 EST.

@rmtemplet
Copy link

Works for me. +1

@hexfusion
Copy link
Contributor

Because core and ep agree this is moving forward.

@racke
Copy link
Member Author

racke commented Nov 4, 2014

Done in master.

@racke racke closed this as completed Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hexfusion hexfusion

Labels
question
Projects
None yet
Milestone
Candy and name cleanup
Development

No branches or pull requests
3 participants
@rmtemplet @racke @hexfusion