Problem with JSON parsing

[frankmichel]

A call to https://api.intercom.io/events returns a 202 response with an empty " " space in it. This causes issues with Guzzle since it cannot be parsed as json:

{"error":{"type":"Guzzle\Common\Exception\RuntimeException","message":"Unable to parse response body into JSON: 4","file":"/home/vagrant/myapp/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Response.php","line":861}}

[nurazem]

@josler Can you have a look at this? The response is indeed not a valid JSON.

[dehora]

Thanks @frankmichel. @nurazem @josler Ideally the server shouldn't return a whitespace artifact, but because the events resource doesn't return JSON the client shouldn't be looking for any on a 2xx response. Looks like the client will need a patch, marking as a bug.

[nurazem]

Hi @dehora. I have looked into the issue and I think that the problem is on the server side. Although, the resource doesn't return JSON, the response's Content-Type header is set to 'application/json'. As you can see below Guzzle is trying to parse the body based on that header.
In Guzzle/Service/Command/DefaultResponseParser.php

public function parse(CommandInterface $command)
{
    $response = $command->getRequest()->getResponse();

    // Account for hard coded content-type values specified in service descriptions
    if ($contentType = $command['command.expects']) {
        $response->setHeader('Content-Type', $contentType);
    } else {
        $contentType = (string) $response->getHeader('Content-Type');
    }

    return $this->handleParsing($command, $response, $contentType);
}

protected function handleParsing(CommandInterface $command, Response $response, $contentType)
{
    $result = $response;
    if ($result->getBody()) {
        if (stripos($contentType, 'json') !== false) {
            $result = $result->json();
        } elseif (stripos($contentType, 'xml') !== false) {
            $result = $result->xml();
        }
    }

    return $result;
}

[aaronfessler]

I am experiencing this bug as well.

[webeng]

Yep, me too.

[aaronfessler]

Hey @josler @nurazem what's the ETA on fixing this? It is pretty easy to repeat and is a showstopper:

use Intercom\IntercomBasicAuthClient;
$intercom = IntercomBasicAuthClient::factory(array(
    'app_id' => "XXXX",
    'api_key' => "YYYY"
));

$intercom->createEvent(array('user_id' => 1, 'created_at'=> time(),'event_name' => 'Code is bogus!'))

Yields this:

Fatal error: Uncaught exception 'Guzzle\Common\Exception\RuntimeException' with message 'Unable to parse response body into JSON: 4' in /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Response.php:861
Stack trace:
#0 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/DefaultResponseParser.php(47): Guzzle\Http\Message\Response->json()
#1 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/OperationResponseParser.php(80): Guzzle\Service\Command\DefaultResponseParser->handleParsing(Object(Guzzle\Service\Command\OperationCommand), Object(Guzzle\Http\Message\Response), 'application/jso...')
#2 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/DefaultResponseParser.php(39): Guzzle\Service\Command\OperationResponseParser->handleParsing(Object(Guzzle\Service\Command\OperationCommand), Object(Guzzle\Http\Message\Response), 'application/jso...')
#3 /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Service/Command/Opera in /Users/aaron/Sites/twine/lib/vendor/guzzle/guzzle/src/Guzzle/Http/Message/Response.php on line 861

Guzzle 4.2.3
Intercom 1.0.0-b3

[josler]

Fixed with v1.0.0-b4!

Thanks.