Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown not working properly #327

Open
joofsh opened this issue Jun 29, 2020 · 0 comments
Open

Shutdown not working properly #327

joofsh opened this issue Jun 29, 2020 · 0 comments

Comments

@joofsh
Copy link

joofsh commented Jun 29, 2020

Version info

  • intercom-rails version: 0.3.5
  • Rails version: 5.2

Expected behavior

Calling IntercomRails::ShutdownHelper.prepare_intercom_shutdown(session) on logout should close/expire the Intercom session

Actual behavior

Two issues with this:

  • According to the documentation this should be sufficient, but this method simply sets a session variable, in order to delete the cookie you also need to call the intercom_shutdown method.
  • According to a recent penetration test of ours, this creates a security vulnerability. This is because calling intercom_shutdown simply deletes the cookie from the current session, but the session is still active on Intercom's end. According to intercom's documentation, the proper way to end a session is by calling their javascript libraries Intercom('shutdown')

Steps to reproduce

  1. Copy a network request to intercom when sending a message
  2. Logout, triggering the gem's intended shutdown code
  3. Resend a similar request. You can continue to send messages to Intercom

Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant