Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility between version 10.2.6 and five-bells-ledger version 19 #111

Closed
michielbdejong opened this issue Mar 15, 2017 · 3 comments
Closed

Comments

@michielbdejong
Copy link
Contributor

Currently, we can probably expect all five-bells-ledger instances to run version 19.4.2, which means they use version 21.0.2 of five-bells-shared. This means the execution_condition field in FiveBellsTransfer objects should start with cc:

Yet, ilp-plugin-bells version 10.2.6 is not prepending this prefix to the base64 executionCondition that is coming from the plugin interface

I'm still looking for ways to confirm that this is actually what happened, but it seems that this incompatibility was not detected by our integration tests (they only look at the latest version of each component, not on the version of each component that is currently used by ilp-kit), and that this is what brought down the Interledger community network. :/

@emschwartz
Copy link
Contributor

I don't think that was an incompatibility because the old ledger plugin interface specified that the execution conditions should have the cc: prefix. Everything was based on Crypto Conditions until we decided to switch to use the plain base64-encoded sha256 hash as the condition in the ledger plugin interface and the Crypto Conditions v2 (implemented by five-bells-condition v5) in the five-bells-ledger.

@michielbdejong
Copy link
Contributor Author

Right, so then we should consider https://github.com/interledger/rfcs/blob/f1bed088b10f8c2f59370d19e8093074acfe4e0d/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#sendTransfer to be the current live version, maybe. I'll think about it some more.

@michielbdejong
Copy link
Contributor Author

This was fixed with the release of ilp-kit v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants