Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login by identifier is broken #122

Open
justmoon opened this issue Apr 21, 2017 · 0 comments
Open

Login by identifier is broken #122

justmoon opened this issue Apr 21, 2017 · 0 comments

Comments

@justmoon
Copy link
Contributor

This commit in ilp-kit removed the ledgerAccount rel from webfinger which broke login via identifier.

interledger-deprecated/ilp-kit@35b7377#diff-70b4ca4f42e3ae499c1764dd3cf2bea8L121

Logging in by account URI is very unintuitive, so we should add some way to log in knowing only the SPSP identifier.

As I see it, there are two options:

  1. Re-add ledgerAccount to the webfinger in ilp-kit.
  2. Split the SPSP identifier at the @, webfinger the hostname to get the ledger uri, then insert the account name into the account url template.

Option no 1 is cleaner, but I don't like adding extra rels if they're not strictly needed.

Option no 2 is more complicated, but might be more robust since it is using only commonly used features.

Thoughts?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justmoon