Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make the API field names more consistent with the node configuration? #286

Closed
emschwartz opened this issue Sep 6, 2019 · 2 comments · Fixed by #328
Closed
Assignees

Comments

@emschwartz
Copy link
Member

We are making a number of breaking changes in #236 to make the naming of config parameters more consistent. Is it worth making a bunch of breaking changes to the API to make the field names more consistent as well? For example, http_endpoint could be http_server_url and btp_uri could be btp_server_url

@gakonst
Copy link
Member

gakonst commented Sep 8, 2019

I'm fine with that. Let's also use that PR as a chance to split out the btp_uri into btp_outgoing_token and btp_server_url (to avoid having to prefix the URI with credentials)

@bstrie
Copy link
Contributor

bstrie commented Sep 9, 2019

I'd say it's now or never. 👍

@emschwartz emschwartz added this to To do in Hackathon Kit via automation Sep 12, 2019
@emschwartz emschwartz moved this from To do to In progress (PRs & Issues) in Hackathon Kit Sep 25, 2019
Hackathon Kit automation moved this from In progress (PRs & Issues) to Done Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Hackathon Kit
  
Done
4 participants