Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of shared test support code #731

Open
koivunej opened this issue Aug 4, 2021 · 0 comments
Open

Refactoring of shared test support code #731

koivunej opened this issue Aug 4, 2021 · 0 comments

Comments

@koivunej
Copy link
Collaborator

koivunej commented Aug 4, 2021

This was noticed while adding the benchmarks in #663 that the redis_helpers.rs is copypasted all over. I do remember attempting to split it, the latest one being KristianWahlroos#2. Since #729 will leave some FIXME and todo! related to these files, maybe they should be refactored into a single place before fixing.

Marking this as good-first-issue because I seem to have made quite small commits which should be easy to follow/replicate.

@koivunej koivunej changed the title redis_helpers refactoring Refactoring of shared test support code Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant