Make Redis fully optional for ilp-node #551
Conversation
|
Do you think it'd be possible to abstract the E2E tests such that they run once with each available backend? So instead of putting everythign under ilp-node/tests/redis, we'd use ilp-node/tests (as is now), and then the test would:
|
Yes, in the long run I would like to share these tests between all the storage backends, since otherwise there would be a substantial amount of duplication. For now though I was planning on doing that later as part of the SQLite backend effort, once it's mature enough to start needing tests. At that point I intend to extract the generic bits out of the tests/redis directory, but since none of it's generic today (and I think that's lower priority than working on the SQLite store itself) I just shoved all of the tests into the redis-specific directory for the time being. |
|
|
||
| #[doc(hidden)] | ||
| #[allow(dead_code)] | ||
| pub fn insert_account_with_redis_store( |
There was a problem hiding this comment.
Is this only used in the tests?
There was a problem hiding this comment.
This isn't used at all in the tests in this repo, but the settlement-engines repo does call this function from its tests. Interestingly, in those tests is the comment // TODO insert the accounts via HTTP request ( https://github.com/interledger-rs/settlement-engines/blob/d8995867751ee62b13bbc4a785588a1a30bff62a/crates/ethereum-engine/tests/eth_ledger_settlement.rs#L85 ), which implies that this function could be removed entirely. @gakonst , how difficult would that be? Does this code simply predate the ability to insert accounts via the HTTP API?
There was a problem hiding this comment.
Does this code simply predate the ability to insert accounts via the HTTP API?
Yes. The tests should be changed to use the CLI or the HTTP API directly
There was a problem hiding this comment.
Since updating settlement-engines seems out of scope at the moment, for now I've just marked this function with the deprecated attribute so that it's less likely to be forgotten about.
There was a problem hiding this comment.
@bstrie Thanks, this is code which existed before we had integrated adding accounts only via the HTTP API. You can safely remove it, and I will add a PR to settlement-engines which converts the E2E tests to not use it anymore. Not difficult at all.
crates/interledger-service-util/src/expiry_shortener_service.rs
Outdated
Show resolved
Hide resolved
bstrie
changed the title
|
Changes addressed and pushed. Note that this PR contains a breaking change to the command-line invocation of ilp-node, as the "redis_url" option has been renamed to "database_url". @dora-gt , do you think this might cause any CI problems? Specifically, I imagine there could be a problem if a new script (using "database_url") somehow gets used to call an old binary (expecting "redis_url"). We could theoretically address this quite easily (search for "XXX" in the PR diff to see what would need to change in order to temporarily support old binaries with new scripts), but I'm not sure whether anybody else thinks this is worth worrying about. |
|
I think the CI failures seen here may be what I was just suggesting in the prior comment. I'll push a version with the aliases and we'll see how CI likes that. @emschwartz , you mentioned that if this happened then you'd want to consider changes to how the CI works? |
|
Rebased. |
BREAKING CHANGE: the "redis_url" command-line option to the ilp-node binary has been renamed to "database_url"
This should be the final part of laying the groundwork for alternative backing databases.