fix: parse account name correctly for subledgers #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -331,7 +331,8 @@ class FiveBellsLedger extends EventEmitter2 { | |||
| } | |||
|
|
|||
| * _send (transfer) { | |||
| const sourceAddress = parseAddress(transfer.account) | |||
| // Strip off the prefix and request id. | |||
| const sourceUsername = transfer.account.slice(this.prefix.length).split('.')[0] | |||
There was a problem hiding this comment.
This behavior should be documented somewhere
There was a problem hiding this comment.
It would also be good to add a test for it
Current coverage is 92.60% (diff: 100%)@@ master #31 diff @@
==========================================
Files 4 4
Lines 260 257 -3
Methods 32 31 -1
Messages 0 0
Branches 62 62
==========================================
- Hits 241 238 -3
Misses 19 19
Partials 0 0
|
|
LGTM. @justmoon might want to review to make sure he agrees with this functionality |
|
Whoops, didn't see this one. #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.