Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify unfulfillable rate probe packets #205

Closed
wilsonianb opened this issue Dec 21, 2021 · 1 comment · Fixed by #730
Closed

Identify unfulfillable rate probe packets #205

wilsonianb opened this issue Dec 21, 2021 · 1 comment · Fixed by #730
Assignees
@wilsonianb
Labels
pkg: backend Changes in the backend package.
Projects
Rafiki Tasks
Milestone
Rafiki v1

Comments

@wilsonianb
Copy link
Contributor

#197 stops balance adjustments from happening at the sending connector for unfulfillable rate probe packets.
Being able do them same for forwarding and receiving connectors would help avoid peer and asset liquidity from being reserved for unfulfillable packets.
@wilsonianb wilsonianb added the pkg: backend Changes in the backend package. label Dec 21, 2021
@wilsonianb wilsonianb added this to Triage in Rafiki Tasks via automation Dec 21, 2021
@wilsonianb wilsonianb moved this from Triage to To do in Rafiki Tasks Dec 21, 2021
@matdehaast matdehaast added this to the Rafiki v1 milestone Aug 16, 2022
@matdehaast
Copy link
Collaborator

@wilsonianb intermediate connectors could never know that the packets are unfulfillable as they can't decode the packet.

I am wondering if there could be an issue though with enabling this on the recievers side. I can't seem to think of anything in particular. @adrianhopebailie @sabineschaller do you think there are any potential footguns in not doing balance adjustments for probing packets?

@wilsonianb wilsonianb mentioned this issue Sep 22, 2022
Closed
@wilsonianb wilsonianb mentioned this issue Nov 3, 2022
Closed
@wilsonianb wilsonianb self-assigned this Nov 4, 2022
@wilsonianb wilsonianb mentioned this issue Nov 4, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilsonianb wilsonianb

Labels
pkg: backend Changes in the backend package.
Projects
No open projects
Rafiki
Status: Done
Rafiki Tasks
To do
Milestone
Rafiki v1
Development

Successfully merging a pull request may close this issue.

chore(backend): skip balance updates on incoming rate probe packets interledger/rafiki
2 participants
@wilsonianb @matdehaast