Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public httpsig library in AS for tests #751

Closed
njlie opened this issue Nov 17, 2022 · 2 comments
Closed

Use public httpsig library in AS for tests #751

njlie opened this issue Nov 17, 2022 · 2 comments
Labels
pkg: auth Changes in the GNAP auth package.
Milestone

Comments

@njlie
Copy link
Contributor

njlie commented Nov 17, 2022

Use publically maintained httpsig library to generate signatures & signature inputs for tests.

@njlie njlie added the pkg: auth Changes in the GNAP auth package. label Nov 17, 2022
@njlie njlie changed the title Use public httpsig library in AS Use public httpsig library in AS for tests Nov 17, 2022
@wilsonianb
Copy link
Contributor

We could export this from open-payments to use in auth:

export const createSignatureHeaders = async ({
request,
privateKey,
keyId
}: SignOptions): Promise<SignatureHeaders> => {

I'm currently throwing together a branch to test the upcoming version of http-message-signatures, which adds signature verification and ed25519 support:

@njlie njlie added this to the GNAP AS milestone Nov 30, 2022
@sabineschaller sabineschaller closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2022
@wilsonianb
Copy link
Contributor

We could open a new issue to use something like 👇 in http-signature-utils for signature verification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package.
Projects
None yet
Development

No branches or pull requests

3 participants