Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments for really small amounts as well for example 0.01 #828

Closed
Tymmmy opened this issue Oct 3, 2023 · 2 comments
Closed

Payments for really small amounts as well for example 0.01 #828

Tymmmy opened this issue Oct 3, 2023 · 2 comments
Labels
package: wallet/backend Wallet backend implementations priority: high

Comments

@Tymmmy
Copy link
Contributor

Tymmmy commented Oct 3, 2023

We need to be able to do Payments for really small amounts as well for example 0.01.
I know fees are an issue here, but we need to do a workaround. Or fix the fees to get percentage of the small amount.
Also can we do accounts for assetScale >2?

@Tymmmy Tymmmy added package: wallet/backend Wallet backend implementations priority: high labels Oct 3, 2023
@Tymmmy Tymmmy added this to the October milestones milestone Oct 4, 2023
@dragosp1011
Copy link
Contributor

On calculating the quote - one unit will be always extracted form the amount for potential transfer lost. This unit is equivalent to 0.01 for asset scale 2. The minimum send amount is 0.02 in this case.
More details in the comment from pay lib: https://github.com/interledgerjs/interledgerjs/blob/fba2dfe8da2e582205632cbbc9433253b7956416/packages/pay/src/index.ts#L385

@Tymmmy
Copy link
Contributor Author

Tymmmy commented Dec 6, 2023

For really small amounts to be sent (especially used in web monetization) we did a quick fix for the ILP Summit 2023.
The fix only allows for USD and assetScale of 9. So some features are hardcoded for now.
We will revisit in the near future.

@Tymmmy Tymmmy closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: wallet/backend Wallet backend implementations priority: high
Projects
Status: Done
Development

No branches or pull requests

2 participants